differentiate flush from quit #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for putting this together. |
|
Oh, BTW, I need to either invert the test order or test stream_disconnects in a different line to make sure it is executed ... |
|
I've uploaded test build r1455 to sourceforge. |
ralph-irving
added a commit
that referenced
this pull request
Dec 29, 2023
Thanks philippe44. Increase squeezelite revision to 1460.
|
Merged. Thank you. |
ralph-irving
added a commit
that referenced
this pull request
Dec 31, 2023
Fix VisualC 2008 build issues. Increase squeezelite revision to 1461.
troudbal
added a commit
to troudbal/squeezelite
that referenced
this pull request
May 20, 2024
Thanks philippe44. Increase squeezelite revision to 1460. (cherry picked from commit c18ab87)
troudbal
pushed a commit
to troudbal/squeezelite
that referenced
this pull request
May 20, 2024
Fix VisualC 2008 build issues. Increase squeezelite revision to 1461. (cherry picked from commit b19b1df) # Conflicts: # output.c
ralph-irving
added a commit
that referenced
this pull request
Dec 10, 2024
Thanks philippe44. Increase squeezelite revision to 1460.
ralph-irving
added a commit
that referenced
this pull request
Dec 10, 2024
Fix VisualC 2008 build issues. Increase squeezelite revision to 1461.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #193, this goes together with LMS-Community/slimserver#964 in trying to address the case where players with large buffers don't allow playlist to be modified at the current track when the next track has already been streamed. It exists with all devices but for the PR on LMS to work, the client has to flush only the streaming track when receiving a strmf.
This PR has been working for far in the tests I've made, but very likely more needs to be verified, so this is rather WIP