This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Add Automatic-Module-Name for Java Modules #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"2" is not a allowed module name and the default way of turning jar-names into Java modules translated into "raml.parser.2" which is not a valid module name, thus preventing this library to be used in a Java module project. This introduced a MANIFEST.MF entry recommended by the Java system to explicitly name the module (removing "2") and this entry should have no affect on exiting non-module projects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"2" is not a allowed module name and the default way of turning
jar-names into Java modules translated into "raml.parser.2" which is not
a valid module name, thus preventing this library to be used in a Java
module project. This introduced a MANIFEST.MF entry recommended by the
Java system to explicitly name the module (removing "2") and this
entry should have no affect on exiting non-module projects.
The error shown was: