-
Notifications
You must be signed in to change notification settings - Fork 0
[feat/button] - 버튼 default / secondary 두가지 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a Button component with two visual variants (default and secondary) styled with a Windows XP-inspired design. The changes include refactoring existing styles and adding Prettier configuration for code formatting consistency.
- Button component with default (gray) and secondary (red) variants
- Windows XP-style styling with box shadows and hover effects
- Code formatting updates with Prettier configuration
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/_variables.scss | Simplified color palette and typography definitions |
| src/styles/_mixins.scss | Enhanced text-style mixin with font-weight parameter |
| src/stories/main.ts | Quote style formatting changes |
| src/componets/Button/Button.tsx | Button component implementation with variant system |
| src/componets/Button/Button.stories.tsx | Storybook configuration for Button component |
| src/componets/Button/Button.scss | Complete styling for both button variants |
| .prettierrc | Prettier configuration for consistent code formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/componets/Button/Button.tsx
Outdated
|
|
||
| export type ButtonProps = React.ButtonHTMLAttributes<HTMLButtonElement> & { | ||
| variant?: "primary" | "secondary"; | ||
| selected?: boolean; |
Copilot
AI
Sep 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The selected prop is defined in the interface but never used in the component implementation. Either implement the functionality or remove this unused prop to avoid confusion.
| selected?: boolean; |
| variant: 'default', | ||
| selected: true, | ||
| color: 'rgba(255, 0, 0, 1)' |
Copilot
AI
Sep 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The story includes selected and color props that are not defined in the ButtonProps interface. Remove these props or add them to the component's prop definitions.
| variant: 'default', | |
| selected: true, | |
| color: 'rgba(255, 0, 0, 1)' | |
| variant: 'default' |
📝 PR 제목
Button 컴포넌트 생성
🛠 변경 내용
🎯 목적 / 이유
✅ 확인 사항