Skip to content

Conversation

@ramong26
Copy link
Owner

📝 PR 제목

Button 컴포넌트 생성


🛠 변경 내용

  • Button default / secondary 두가지 모양

🎯 목적 / 이유

image image ---

✅ 확인 사항

  • 빌드 통과 ✅
  • 테스트 통과 ✅
  • 불필요한 console.log 제거 ✅

@ramong26 ramong26 requested a review from Copilot September 15, 2025 05:21
@ramong26 ramong26 self-assigned this Sep 15, 2025
@ramong26 ramong26 linked an issue Sep 15, 2025 that may be closed by this pull request
@ramong26 ramong26 added the feat This issue or pull request a new feature label Sep 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a Button component with two visual variants (default and secondary) styled with a Windows XP-inspired design. The changes include refactoring existing styles and adding Prettier configuration for code formatting consistency.

  • Button component with default (gray) and secondary (red) variants
  • Windows XP-style styling with box shadows and hover effects
  • Code formatting updates with Prettier configuration

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/styles/_variables.scss Simplified color palette and typography definitions
src/styles/_mixins.scss Enhanced text-style mixin with font-weight parameter
src/stories/main.ts Quote style formatting changes
src/componets/Button/Button.tsx Button component implementation with variant system
src/componets/Button/Button.stories.tsx Storybook configuration for Button component
src/componets/Button/Button.scss Complete styling for both button variants
.prettierrc Prettier configuration for consistent code formatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


export type ButtonProps = React.ButtonHTMLAttributes<HTMLButtonElement> & {
variant?: "primary" | "secondary";
selected?: boolean;
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selected prop is defined in the interface but never used in the component implementation. Either implement the functionality or remove this unused prop to avoid confusion.

Suggested change
selected?: boolean;

Copilot uses AI. Check for mistakes.
Comment on lines 16 to 18
variant: 'default',
selected: true,
color: 'rgba(255, 0, 0, 1)'
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The story includes selected and color props that are not defined in the ButtonProps interface. Remove these props or add them to the component's prop definitions.

Suggested change
variant: 'default',
selected: true,
color: 'rgba(255, 0, 0, 1)'
variant: 'default'

Copilot uses AI. Check for mistakes.
@ramong26 ramong26 merged commit f951a25 into main Sep 15, 2025
2 checks passed
@ramong26 ramong26 changed the title feat/button - 버튼 default / secondary 두가지 [feat/button] - 버튼 default / secondary 두가지 Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat This issue or pull request a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat/button] - 기본적인 버튼 컴포넌트 구현

2 participants