Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Electron to v30 #7000

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Upgrade Electron to v30 #7000

merged 3 commits into from
Jun 13, 2024

Commits on Jun 5, 2024

  1. Bump electron to 30 

    This is not expected to build; it's just a checkpoint.

Signed-off-by: Mark Yen <[email protected]>
    @mook-as
    mook-as committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    7c3762a View commit details
    Browse the repository at this point in the history

  2. Electron: drop use of deprecated BrowserView 

    `BrowserView` is now fully deprecated; replace its functionality using
`WebContentsView` instead.

- Change the layout so that we determine the extensions view size by using
  a `<div>` of the desired size (hidden behind other content).
- Since `WebContentsView` has no `setAutoResize`, manually resize the
  extensions view when the main content view size has changed, as well as
  on zoom change.
- Rewrite zoom implementation so it adjusts the zoom of all child views
  directly instead of using keyboard events.
- Use custom menu even on development builds (so that our new zoom code can
  be correctly triggered).

Signed-off-by: Mark Yen <[email protected]>
    @mook-as
    mook-as committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    1d0b017 View commit details
    Browse the repository at this point in the history

  3. Package: Disable asar integrity on Windows 

    Electron-builder doesn't yet support asar integrity on Windows; disable it
so that the packaged version can start up.  This is new on Windows in
Electron 30 (previously it was only possible on macOS).

Signed-off-by: Mark Yen <[email protected]>
    @mook-as
    mook-as committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d5e7c74 View commit details
    Browse the repository at this point in the history