Not always listen on TCP #7617
Merged
Not always listen on TCP #7617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
previously approved these changes
Oct 10, 2024
| @@ -88,6 +88,8 @@ func (a *APITracker) Add(containerID string, portMap nat.PortMap) error { | |||
| for portProto, portBindings := range portMap { | |||
| var tmpPortBinding []nat.PortBinding | |||
|
|
|||
| log.Infof("PortProto: %+v, PortBindings: %+v\n", portProto, portBindings) | |||
There was a problem hiding this comment.
Is Infof infrequent enough when everything is going right and the user keeps this running over a week?
There was a problem hiding this comment.
Oops, that should be Debugf
Nino-K
force-pushed
the
allow-listening-udp
branch
from
d950da6
to
36d2b6e
Compare
mook-as
approved these changes
Oct 10, 2024
This change provides the protocol when calling expose or unexpose API requests. This is vital to ensure we listen on the correct protocol instead of always defaulting to TCP. Signed-off-by: Nino Kodabande <[email protected]>
Nino-K
force-pushed
the
allow-listening-udp
branch
from
36d2b6e
to
2e940b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides the protocol when calling expose or unexposed API requests. This is vital to ensure we listen to the correct protocol instead of defaulting to TCP.
Fixes: #6821
Also, addresses: #7473 and #4873