Fixes empty portmapping forward #7764
Open
+45
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the logs outputs were encountering `*fmt.wrapError` type `!w` in the logs. This change addresses the wrong format output. Also, makes the logs in watcher_linux.go to match the rest of log formats. Signed-off-by: Nino Kodabande <[email protected]>
Vtunnel is no longer used, therefore, renaming the file to forwarder.go Signed-off-by: Nino Kodabande <[email protected]>
Previously, the portStorage.Add and WSLProxy.Send functions were called with an empty portMapping. This change adds a check for the length of portMapping before calling these functions, making sure they are only invoked when necessary. Signed-off-by: Nino Kodabande <[email protected]>
When portTracker.Add fails, we should simply continue without attempting to recreate the loopback iptables rule. Signed-off-by: Nino Kodabande <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API Tracker in guestAgent was calling certain functions without checking if portMapping had any entries. While this didn’t break the logic, it resulted in unnecessary function calls with empty portMapping, making the code less efficient and cluttering the logs with irrelevant information.
Fixes: #7763