-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rke2 registration token generated twice #236
Merged
alexander-demicev
merged 1 commit into
rancher:main
from
salasberryfin:fix-rke2-registration-token-created-twice
Jan 17, 2024
Merged
fix: rke2 registration token generated twice #236
alexander-demicev
merged 1 commit into
rancher:main
from
salasberryfin:fix-rke2-registration-token-created-twice
Jan 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
force-pushed
the
fix-rke2-registration-token-created-twice
branch
from
January 12, 2024 16:31
4f52666
to
1f6bccd
Compare
salasberryfin
changed the title
WIP: fix: rke2 registration token generated twice
fix: rke2 registration token generated twice
Jan 15, 2024
tmmorin
reviewed
Jan 15, 2024
salasberryfin
force-pushed
the
fix-rke2-registration-token-created-twice
branch
from
January 16, 2024 10:44
1f6bccd
to
f77363a
Compare
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
fix-rke2-registration-token-created-twice
branch
from
January 16, 2024 11:28
f77363a
to
4f5c993
Compare
PR is now updated based on review feedback. Current logic will:
|
Danil-Grigorev
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
richardcase
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally and i didn't see the same duplicate token creation.
alexander-demicev
approved these changes
Jan 17, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The RKE2 Config controller is creating the registration token twice (intermittently) and updating the secret that contains the token so different nodes are trying to get registered with different tokens and failing to do so.
We must ensure this secret is created once and its value remains unedited so that nodes can be registered to the cluster.
This initial proposal suggests detecting if the secret exists and skip token creation if it does.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #233
Special notes for your reviewer:
We should add test cases that cover the logic of this controller: ##235 tracks this follow-up issue.
Checklist: