Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "meta-data" to userDataFiles string list Refers #2125 #2126

Closed

Conversation

robertwbl
Copy link

As suggested in the issue I've raised, this allows cloud-init on toolkit built images to pick up cloud config in files named "meta-data" such as the one Harvester provides instance data in.

@robertwbl robertwbl requested a review from a team as a code owner July 1, 2024 09:03
@robertwbl
Copy link
Author

It has occurred to me that perhaps this change is better made upstream here: https://github.com/rancher-sandbox/linuxkit/blob/main/providers/provider_cdrom.go ?

Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has occurred to me that perhaps this change is better made upstream here: https://github.com/rancher-sandbox/linuxkit/blob/main/providers/provider_cdrom.go ?

Indeed, this vendored folder it autogenerated. Hence no changes there should be done there. We'd appreciate if you make the equivalent PR in https://github.com/rancher-sandbox/linuxkit repository and then we will take it from there, make a new release of the library, update the yip dependency and finally update the elemental-toolkit itself.

Does it sound good?

@robertwbl
Copy link
Author

Thanks @davidcassany that sounds good. I've opened rancher-sandbox/linuxkit#5 and am closing this PR.

@robertwbl robertwbl closed this Jul 1, 2024
@robertwbl robertwbl deleted the cd_rom_provider_add_meta_data branch July 1, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants