Split pkg/helmvalues into its own Go module#5396
Open
0xavi0 wants to merge 1 commit into
Open
Conversation
Promote pkg/helmvalues to a standalone module (like pkg/apis) so it can be released and consumed independently by rancher/rancher. Also adds check-module-tag-sync.sh + workflow to verify pkg/apis and pkg/helmvalues are tagged in lockstep (same version, same commit) Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR promotes pkg/helmvalues into its own standalone Go module (similar to pkg/apis) so it can be versioned and consumed independently (e.g., by rancher/rancher). It also adds automation to ensure pkg/apis and pkg/helmvalues are tagged/released in lockstep.
Changes:
- Introduces a new Go module under
pkg/helmvalues/(go.mod+go.sum) and wires it into the root module viareplace/require. - Adds a new workflow + script to verify
pkg/apisandpkg/helmvaluestags are synchronized (same version and commit, and matching inter-module requirement). - Updates CI and release tooling to test/bump the new
pkg/helmvaluesmodule.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/helmvalues/go.mod | Adds a standalone module definition for pkg/helmvalues. |
| pkg/helmvalues/go.sum | Adds dependency checksums for the new pkg/helmvalues module. |
| go.mod | Adds replace + require entries so the root module can reference the new submodule. |
| .github/workflows/ci.yml | Adds a dedicated unit-test step for the pkg/helmvalues module. |
| .github/workflows/release-against-rancher.yml | Extends pre-flight tag/version guards to cover pkg/helmvalues. |
| .github/scripts/release-against-rancher.sh | Updates the bump logic to optionally bump pkg/helmvalues in rancher/rancher when tagged. |
| .github/scripts/check-module-tag-sync.sh | Adds a script to validate pkg/apis + pkg/helmvalues tag/commit/version lockstep. |
| .github/workflows/check-module-tags.yml | Adds a workflow to run the tag-sync validation on tag push / manual trigger. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote pkg/helmvalues to a standalone module (like pkg/apis) so it can be released and consumed independently by rancher/rancher.
Also adds check-module-tag-sync.sh + workflow to verify pkg/apis and pkg/helmvalues are tagged in lockstep (same version, same commit)
Additional Information
Checklist
- [ ] I have updated the documentation via a pull request in the fleet-product-docs repository.