Add updatecli policy #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgfritch
reviewed
May 14, 2024
| name: Get latest Golang version based on go.mod | ||
| kind: file | ||
| spec: | ||
| file: https://raw.githubusercontent.com/kubernetes-sigs/cri-tools/master/go.mod |
There was a problem hiding this comment.
Query the go version from the tag defined by the image-build instead of the master branch?
$ curl https://raw.githubusercontent.com/kubernetes-sigs/cri-tools/v1.26.1/go.mod 2>/dev/null | egrep 'go ([0-9]+\.[0-9]+)'
go 1.19
$ curl https://raw.githubusercontent.com/kubernetes-sigs/cri-tools/master/go.mod 2>/dev/null | egrep 'go ([0-9]+\.[0-9]+)'
go 1.22.0
There was a problem hiding this comment.
I thought about that but if you check the releases, we are not really updating that tag and releasing new versions that overwrite that tag. I thought using the master would be ok since we want to be always in sync with upstream k8s releases
Signed-off-by: Manuel Buil <[email protected]>
thomasferrandiz
approved these changes
May 15, 2024
mgfritch
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add updatecli policy to update the go version
Works: #27