publish-image action #113
Merged
publish-image action #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brooksn
commented
Sep 11, 2024
•
brooksn
commented
- use rancher/ecm-distro-tools/actions/publish-image to build and push images
- adds make target push-image
- adds sbom to docker build arguments
- signs images that are pushed to the prime registry
Signed-off-by: Brooks Newberry <[email protected]>
Signed-off-by: Brooks Newberry <[email protected]>
manuelbuil
reviewed
Sep 27, 2024
| .PHONY: image-build | ||
| image-build: | ||
| docker build \ | ||
| $(BUILD_OPTS) \ | ||
| --pull \ |
There was a problem hiding this comment.
I saw that in some repos we are using --pull and --load whereas in this one we only have --pull, could that be a problem?
There was a problem hiding this comment.
This should not cause any problems. The image-build make target is only used in local development, and I left the --pull option in place if it was already there.
manuelbuil
approved these changes
Sep 30, 2024
thomasferrandiz
approved these changes
Sep 30, 2024
Signed-off-by: Brooks Newberry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.