Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

refactor install.sh #606

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor install.sh #606

wants to merge 2 commits into from

Conversation

Gorian
Copy link

@Gorian Gorian commented Nov 4, 2020

Refactor includes:

  • replacing calls to external programs with bash internals or keywords where applicable
  • passes shellcheck - https://shellcheck.net
  • optimizing some code where applicable
  • replacing multiple lines of echo with heredocs

Refactor includes:
- replacing calls to external programs with bash internals or keywords where applicable
- Shell passes shellcheck - https://shellcheck.net
- optimizing some code where applicable
- replacing multiple lines of echo with heredocs
Copy link

@avanier avanier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compliance to shellcheck feels really good here. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants