-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policy report results to dashboard view #819
base: main
Are you sure you want to change the base?
Conversation
Functionality-wise I did not find any problem. I have few suggestions / notes about my initial confusion :)
|
description: An Admission Policy is a namespace-wide resource. The policy will process only the requests that are targeting the Namespace where the Admission Policy is defined. | ||
linkText: Create Admission Policy | ||
slotTitle: Policies | ||
title: Namespace Policies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this it typo or correct :)
title: Namespace Policies | |
title: Namespaced Policies |
slotTitle: Policies | ||
title: Namespace Policies | ||
description: Namespace-wide policy validation | ||
linkText: Create Namespace Policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
linkText: Create Namespace Policy | |
linkText: Create Namespaced Policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise, LGTM
Holding off on this until the UX team can take a look. |
Fix #798
This adds policy report results to the dashboard view.
Along with the reports added, the layout of the cards has been updated.