Skip to content

fix: don't try to clean up pvs on nodes that are gone #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derekbit merged 1 commit into from
Jul 31, 2025
Merged

fix: don't try to clean up pvs on nodes that are gone #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions provisioner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,11 @@ func (p *LocalPathProvisioner) deleteFor(pv *v1.PersistentVolume, c *StorageClas
if node == "" {
logrus.Infof("Deleting volume %v at %v", pv.Name, path)
} else {
// Check if node still exists
if _, err := p.kubeClient.CoreV1().Nodes().Get(context.TODO(), node, metav1.GetOptions{}); err != nil && k8serror.IsNotFound(err) {
logrus.Infof("Node %v does not exist, skipping cleanup of volume %v", node, pv.Name)
return nil
}
logrus.Infof("Deleting volume %v at %v:%v", pv.Name, node, path)
}
storage := pv.Spec.Capacity[v1.ResourceName(v1.ResourceStorage)]
Expand Down