Better handle pv deletion when node name is in annotations #532
Conversation
|
@derekbit can you please help to take a look? |
There was a problem hiding this comment.
Pull request overview
This PR improves the robustness of persistent volume (PV) deletion by adding fallback logic to retrieve the node name from the local.path.provisioner/selected-node annotation when NodeAffinity information is missing or invalid. This addresses scenarios where PVs might have incomplete or corrupted NodeAffinity specifications but still have the annotation set during provisioning.
Key Changes:
- Added annotation-based node name retrieval as a fallback mechanism when NodeAffinity is unavailable
- Improved error messages to reference the missing annotation when both NodeAffinity and annotation are absent
- Added debug logging when NodeAffinity and annotation values differ, with NodeAffinity taking precedence
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if annoNode != "" { | ||
| return path, annoNode, nil | ||
| } | ||
| return "", "", fmt.Errorf("cannot find affinited node and missing %s annotation", nodeNameAnnotationKey) |
There was a problem hiding this comment.
"affinited" is not a proper English word. Consider using "node with affinity" or "affinity-matched node" instead.
| return "", "", fmt.Errorf("cannot find affinited node and missing %s annotation", nodeNameAnnotationKey) | |
| return "", "", fmt.Errorf("cannot find affinity-matched node and missing %s annotation", nodeNameAnnotationKey) |
|
@anson627 |
2 participants
fix #533