Fix Hidden property of linux-polska/ezd-crd upstream.yaml and annotations on its latest chart version
#1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recena
reviewed
Oct 10, 2024
| @@ -1,6 +1,7 @@ | |||
| annotations: | |||
| catalog.cattle.io/certified: partner | |||
| catalog.cattle.io/display-name: CRDs for LP Backend | |||
| catalog.cattle.io/hidden: "true" | |||
There was a problem hiding this comment.
What is the meaning of this annotation?
There was a problem hiding this comment.
It causes the chart to not be shown by the UI. In the partner charts repository it is used in only the linux-polska/ezd-crd package (this one). I think it is used here because it is effectively a CRD chart for linux-polska/ezd-backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in
partner-charts-ci(see rancher/partner-charts-ci#30) that resulted in the latest version of theezd-crdchart not having thecatalog.cattle.io/hiddenannotation. This PR fixes that. It also addsHidden: trueto theupstream.yamloflinux-polska/ezd-crd.