Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the stackstate-k8s-agent in favor of the SUSE Observability agent #1076

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

craffit
Copy link
Contributor

@craffit craffit commented Oct 10, 2024

StackState was rebranded to SUSE observability and the agent chart to SUSE Observability Agent

The SUSE Observability Agent chart is distributed as part of the rancher prime chart repository, so this chart is now deprecated.

@craffit craffit requested a review from a team as a code owner October 10, 2024 06:36
@recena recena merged commit 017ee13 into rancher:main-source Oct 10, 2024
1 check passed
@adamkpickering
Copy link
Collaborator

Hi @craffit and @recena, this isn't the right way to deprecate a chart. The right way is to use the partner-charts-ci deprecate command. This sets Deprecated: true in upstream.yaml, but also adds deprecated: true to the Chart.yaml of each chart version for that chart. This second part is important because it makes the chart show up as deprecated in the rancher UI.

@craffit is there any chance you could submit another PR for this that uses partner-charts-ci deprecate?

I will update the documentation for the Deprecated field (and the Hidden field, where this also applies) so that this doesn't happen in the future.

@recena
Copy link
Collaborator

recena commented Oct 10, 2024

You are right. My mistake. @adamkpickering Can you revert this PR and prepare a new one?

@adamkpickering
Copy link
Collaborator

Certainly. @craffit please disregard my previous request. I'll have another PR up shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants