fix: enable TLS verification for Rancher API auth calls#253
Draft
andypitcher wants to merge 1 commit into
Draft
Conversation
andypitcher
force-pushed
the
fix/auth-tls-verification
branch
from
245509e to
c86c99d
Compare
Replace hardcoded verify=False with _build_ssl_context() that uses system CAs supplemented by the in-cluster SA ca.crt. Security hardening: - Fail-closed: TLS verification ON by default - Strict INSECURE_SKIP_TLS parsing (true/false only, ValueError on invalid) - SSL_CERT_FILE raises FileNotFoundError if set but missing - Warning logged when TLS verification is disabled - RANCHER_URL scheme normalization preserved for schemeless inputs Test and build infrastructure: - Add unit tests for auth module (tests/unit/services/test_auth.py) - Add Dockerfile.test and Makefile test target Signed-off-by: Andy Pitcher <andy.pitcher@suse.com>
andypitcher
force-pushed
the
fix/auth-tls-verification
branch
from
c86c99d to
56b5023
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve auth.py
Replace hardcoded verify=False with _build_ssl_context() that uses system CAs supplemented by the in-cluster SA ca.crt. Respects INSECURE_SKIP_TLS and SSL_CERT_FILE env vars.
Add unit tests and test infrastructure