Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #184

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Bump dependencies #184

merged 6 commits into from
Jun 12, 2024

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Jun 11, 2024

No description provided.

Copy link
Contributor

@manuelbuil manuelbuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that weave CNI deprecation should be following this plan:
Weave is deprecated in 1.27, 1.28 and 1.29. Weave will be removed in 1.30 as stated here: rancher/rancher#42730

Comment on lines 62 to 78
RUN xx-verify --static /tmp/bandwidth \
&& xx-verify --static /tmp/bridge \
&& xx-verify --static /tmp/dhcp \
&& xx-verify --static /tmp/firewall \
&& xx-verify --static /tmp/flannel \
&& xx-verify --static /tmp/host-device \
&& xx-verify --static /tmp/host-local \
&& xx-verify --static /tmp/ipvlan \
&& xx-verify --static /tmp/loopback \
&& xx-verify --static /tmp/macvlan \
&& xx-verify --static /tmp/portmap \
&& xx-verify --static /tmp/ptp \
&& xx-verify --static /tmp/sbr \
&& xx-verify --static /tmp/static \
&& xx-verify --static /tmp/tuning \
&& xx-verify --static /tmp/vlan \
&& xx-verify --static /tmp/vrf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these binaries used for the other CNI plugins (e.g. flannel needs the bridge CNI plugin)? They might come from another place but just in case I ask

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I created this issue when I was looking at RKE1 but I never had time: rancher/rke#3327

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these binaries used for the other CNI plugins (e.g. flannel needs the bridge CNI plugin)?

I could not find anywhere else looking for those files at /tmp/ apart from the Weave CNI tbh. But happy to follow that up as part of the issue you created on RKE.

Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
@pjbgf pjbgf changed the title Bump dependencies and removal of weave CNI Bump dependencies Jun 11, 2024
@pjbgf
Copy link
Member Author

pjbgf commented Jun 11, 2024

@manuelbuil thank you for the review and linking up the other issues. I reverted the changes around removal of Weave CNI for the time being. Instead I have just bumped their versions instead. PTAL

@kinarashah kinarashah merged commit 4cac8b5 into rancher:master Jun 12, 2024
3 checks passed
@pjbgf pjbgf deleted the bumps branch June 13, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants