feat: add acceptance test framework #4301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoral2
force-pushed
the
master
branch
3 times, most recently
from
2bfcf42
to
a8508a2
Compare
fmoral2
changed the title
fmoral2
force-pushed
the
master
branch
3 times, most recently
from
907c6ba
to
99ea995
Compare
briandowns
reviewed
May 31, 2023
briandowns
reviewed
May 31, 2023
briandowns
reviewed
May 31, 2023
fmoral2
force-pushed
the
master
branch
3 times, most recently
from
e28ad5d
to
0d8005b
Compare
Signed-off-by: Francisco <[email protected]>
fmoral2
force-pushed
the
master
branch
4 times, most recently
from
4fff641
to
0b2d609
Compare
fmoral2
force-pushed
the
master
branch
2 times, most recently
from
4e7bc80
to
c2057e4
Compare
Signed-off-by: Francisco <[email protected]>
fmoral2
force-pushed
the
master
branch
2 times, most recently
from
eac2168
to
ebefc38
Compare
| } else if strings.Contains(pod.Name, "apply") && | ||
| strings.Contains(pod.NameSpace, "system-upgrade") { | ||
| g.Expect(pod.Status).Should(SatisfyAny( | ||
| ContainSubstring("Error"), |
There was a problem hiding this comment.
What if it is actually an Error? Could we wait longer for job to complete?
There was a problem hiding this comment.
this error we are only expecting from this namespace system-upgrade ,only for the apply pods which sometimes can occur and then it continues with a new pod to do the job.
If this pod only return error , we will catch later on the upgrade validations , that will try to assert that the nodes are in a new version but will not be .
If we remove this error , this test become too much flaky for no reason.
tests/acceptance/shared/cluster.go
Outdated
| } | ||
|
|
||
| // Pods returns pods parsed from kubectl get pods. | ||
| func Pods(print bool) ([]Pod, error) { |
There was a problem hiding this comment.
Let's retain the name ParsePods as per its functionality
tests/acceptance/shared/cluster.go
Outdated
| } | ||
|
|
||
| // Nodes returns nodes parsed from kubectl get nodes. | ||
| func Nodes(print bool) ([]Node, error) { |
There was a problem hiding this comment.
ParseNodes instead?
fmoral2
force-pushed
the
master
branch
3 times, most recently
from
958ce2c
to
7ba6a0b
Compare
Signed-off-by: Francisco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments
Next Steps: