Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply netpols async with retry #5909

Merged
merged 1 commit into from
May 23, 2024

Conversation

brandond
Copy link
Member

Proposed Changes

Instead of failing RKE2 startup if the network policies cannot be updated, sync them in the background with retry.

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner May 10, 2024 18:12
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 26.42%. Comparing base (8b577f6) to head (8cf86c3).
Report is 14 commits behind head on master.

Files Patch % Lines
pkg/rke2/np.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5909      +/-   ##
==========================================
- Coverage   26.46%   26.42%   -0.04%     
==========================================
  Files          30       30              
  Lines        2649     2653       +4     
==========================================
  Hits          701      701              
- Misses       1903     1907       +4     
  Partials       45       45              
Flag Coverage Δ
inttests 9.98% <0.00%> (-0.02%) ⬇️
unittests 18.77% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants