-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test about mixedos+flannel #6063
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6063 +/- ##
==========================================
- Coverage 26.10% 9.82% -16.29%
==========================================
Files 32 32
Lines 2697 2698 +1
==========================================
- Hits 704 265 -439
- Misses 1947 2411 +464
+ Partials 46 22 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you merge the two mixedos
e2e test together, and just have CNI be a variable similar to https://github.com/rancher/rke2/blob/master/tests/e2e/validatecluster/Vagrantfile#L10?
As long as @ShylajaDevadiga can confirm that we can change that variable in her scripts to run https://rke2-results.s3.us-east-2.amazonaws.com/rke2_ubuntu2004_results.html, then yes :) |
Signed-off-by: Manuel Buil <[email protected]>
7d981ab
to
ef51ff6
Compare
Proposed Changes
Adds support for cni: flannel in the mixedos test
Types of Changes
New test
Verification
E2E_CNI=flannel go test -v -timeout=30m tests/e2e/mixedos/mixedos_test.go
Testing
Linked Issues
User-Facing Change
Further Comments