Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test about mixedos+flannel #6063

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

manuelbuil
Copy link
Contributor

@manuelbuil manuelbuil commented May 30, 2024

Proposed Changes

Adds support for cni: flannel in the mixedos test

Types of Changes

New test

Verification

E2E_CNI=flannel go test -v -timeout=30m tests/e2e/mixedos/mixedos_test.go

Testing

Linked Issues

User-Facing Change


Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner May 30, 2024 11:15
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.82%. Comparing base (71d00cc) to head (ef51ff6).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #6063       +/-   ##
==========================================
- Coverage   26.10%   9.82%   -16.29%     
==========================================
  Files          32      32               
  Lines        2697    2698        +1     
==========================================
- Hits          704     265      -439     
- Misses       1947    2411      +464     
+ Partials       46      22       -24     
Flag Coverage Δ
inttests 9.82% <ø> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the two mixedos e2e test together, and just have CNI be a variable similar to https://github.com/rancher/rke2/blob/master/tests/e2e/validatecluster/Vagrantfile#L10?

@brandond brandond self-requested a review May 30, 2024 18:50
@manuelbuil
Copy link
Contributor Author

Can you merge the two mixedos e2e test together, and just have CNI be a variable similar to https://github.com/rancher/rke2/blob/master/tests/e2e/validatecluster/Vagrantfile#L10?

As long as @ShylajaDevadiga can confirm that we can change that variable in her scripts to run https://rke2-results.s3.us-east-2.amazonaws.com/rke2_ubuntu2004_results.html, then yes :)

@manuelbuil manuelbuil merged commit 311b3a5 into rancher:master Jul 10, 2024
5 checks passed
@manuelbuil manuelbuil deleted the mixedosflannel branch July 10, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants