-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving logging and error readability for rke2-uninstall.sh script #6237
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6237 +/- ##
=======================================
Coverage 25.18% 25.18%
=======================================
Files 33 33
Lines 2831 2831
=======================================
Hits 713 713
Misses 2071 2071
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please rebase your changes on top of current master. |
Signed-off-by: Jake Hyde <[email protected]>
Done @brandond |
@brandond Can you please merge the PR if there is no further issues? |
I would probably hold off until after the current release is done, since the install script gets bundled into system-agent-installer-rke2. |
Okay @brandond , when is the release planned? I will remind after the release once. Thanks |
Proposed Changes
Currently, whenever uninstall script fails it is not immediately clear that it failed and we need to address the failure issues. These changes adds clear messaging in red colour if the script fails at any point with better logging.
It doesn't need documentation changes
Types of Changes
Improving logging and error readability in rke2-uninstall script
Verification
Changes can be verified by running the uninstall script on rancher based system
Testing
It doesn't have any changes which need unit tests or integration tests
Linked Issues
User-Facing Change
Further Comments