Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vagrantfile of a few e2e tests #6274

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

manuelbuil
Copy link
Contributor

Proposed Changes

Remove the bind-address arg which is not needed and could be problematic if we use kubectl exec ... like in the cilium e2e test due to k3s-io/k3s#10444

Besides, kubelet-arg: "--node-ip=0.0.0.0" is not needed anymore. That was fixed upstream

Types of Changes

Update e2e tests

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner July 2, 2024 14:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.82%. Comparing base (f01072a) to head (5150b93).

❗ There is a different number of reports uploaded between BASE (f01072a) and HEAD (5150b93). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (f01072a) HEAD (5150b93)
unittests 3 0
inttests 3 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #6274       +/-   ##
==========================================
- Coverage   26.09%   9.82%   -16.28%     
==========================================
  Files          32      32               
  Lines        2698    2698               
==========================================
- Hits          704     265      -439     
- Misses       1948    2411      +463     
+ Partials       46      22       -24     
Flag Coverage Δ
inttests 9.82% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelbuil
Copy link
Contributor Author

Merging with Brooks' and Max' blessing

@manuelbuil manuelbuil merged commit 9684c25 into rancher:master Jul 4, 2024
5 checks passed
@manuelbuil manuelbuil deleted the e2etestsupdate branch July 4, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants