Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.29] version bumps and backports for 2024-07 release cycle #6318

Merged

Conversation

brandond
Copy link
Member

@brandond brandond commented Jul 15, 2024

brandond and others added 9 commits July 15, 2024 18:12
Fixed an issue where failing to include APIGroup on the subjects caused the reconcile helpers to think the subject needed to be re-added every time RKE2 starts up.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit af73b78)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 8121a5e)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Jake Hyde <[email protected]>
(cherry picked from commit aa33fa4)
Signed-off-by: Brad Davidson <[email protected]>
Bumps [github.com/hashicorp/go-retryablehttp](https://github.com/hashicorp/go-retryablehttp) from 0.7.4 to 0.7.7.
- [Changelog](https://github.com/hashicorp/go-retryablehttp/blob/main/CHANGELOG.md)
- [Commits](hashicorp/go-retryablehttp@v0.7.4...v0.7.7)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-retryablehttp
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit d3abda1)
Signed-off-by: Brad Davidson <[email protected]>
Bumps alpine from 3.19 to 3.20.

---
updated-dependencies:
- dependency-name: alpine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit 6229777)
Signed-off-by: Brad Davidson <[email protected]>
* Add new --ingress-controller CLI flag
* Refactor --ingress-controller and --cni flags to use common helper for
  disabling all unused charts
* Wire first ingress controller name into global.systemDefaultIngressClass
  chart variable

NOTE: Support for the traefik chart is NOT being backported to older
minors. The flag to select an alternative ingress controller is
hidden and only supports ingress-nginx. The rest of the changes are
being backported to keep the older branches consistent with master and
allow newer releases of the ingress-nginx chart to function properly on
older minors.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 76d4fb3)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 3134a11)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner July 15, 2024 18:46
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 13.41463% with 71 lines in your changes missing coverage. Please review.

Project coverage is 25.87%. Comparing base (3ae4f86) to head (8fa9fe5).

Files Patch % Lines
pkg/cli/cmds/server.go 0.00% 46 Missing ⚠️
pkg/rke2/clusterrole.go 0.00% 14 Missing ⚠️
pkg/bootstrap/bootstrap.go 0.00% 4 Missing ⚠️
pkg/rke2/clusterrole_bootstrap.go 0.00% 2 Missing ⚠️
pkg/rke2/rke2_linux.go 50.00% 1 Missing and 1 partial ⚠️
pkg/cli/defaults/defaults.go 0.00% 0 Missing and 1 partial ⚠️
pkg/podexecutor/staticpod.go 0.00% 1 Missing ⚠️
pkg/rke2/rke2.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29    #6318      +/-   ##
================================================
- Coverage         26.09%   25.87%   -0.22%     
================================================
  Files                32       32              
  Lines              2698     2736      +38     
================================================
+ Hits                704      708       +4     
- Misses             1948     1981      +33     
- Partials             46       47       +1     
Flag Coverage Δ
inttests 9.75% <10.97%> (-0.07%) ⬇️
unittests 18.38% <2.43%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 0381723 into rancher:release-1.29 Jul 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants