Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test bug in mixedosbgp #6840

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

manuelbuil
Copy link
Contributor

Proposed Changes

This PR fixes a bug in the mixedosbgp e2e test. -Commit= is wrong, the equal symbol should be removed. We were getting an error when installing rke2 in windows.

Types of Changes

Bugfix

Verification

Run the e2e test

Testing

Linked Issues

User-Facing Change


Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner September 18, 2024 08:20
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.54%. Comparing base (b8dfafa) to head (fb38f55).

❗ There is a different number of reports uploaded between BASE (b8dfafa) and HEAD (fb38f55). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b8dfafa) HEAD (fb38f55)
unittests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #6840       +/-   ##
==========================================
- Coverage   25.11%   9.54%   -15.57%     
==========================================
  Files          33      33               
  Lines        2839    2839               
==========================================
- Hits          713     271      -442     
- Misses       2079    2545      +466     
+ Partials       47      23       -24     
Flag Coverage Δ
inttests 9.54% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelbuil manuelbuil merged commit 272b99c into rancher:master Sep 19, 2024
6 checks passed
@manuelbuil manuelbuil deleted the fixMixedOS branch September 19, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants