Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docker tests into tests folder, fix nightly #6855

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Sep 23, 2024

Proposed Changes

  • Move docker tests into test directory
  • Consolidate the out of date install test READMEs into a single document with up to date information.
  • Fix nightly install tests (example failure)

Types of Changes

Code cleanup

Verification

GHA passes run, specifically
dapper -f Dockerfile --target dapper make test still works

Testing

Its all testing

Linked Issues

#5678

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner September 23, 2024 17:11
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.11%. Comparing base (b8dfafa) to head (87cc277).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6855   +/-   ##
=======================================
  Coverage   25.11%   25.11%           
=======================================
  Files          33       33           
  Lines        2839     2839           
=======================================
  Hits          713      713           
  Misses       2079     2079           
  Partials       47       47           
Flag Coverage Δ
inttests 9.54% <ø> (ø)
unittests 17.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola changed the title Move docker tests into tests folder Move docker tests into tests folder, fix nightly Sep 23, 2024
@dereknola dereknola merged commit da7f243 into rancher:master Sep 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants