Skip to content

#609: Registries Configuration summary section overflows on smaller screens #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xingzhang-suse merged 2 commits into from
Jun 17, 2026
Merged

#609: Registries Configuration summary section overflows on smaller screens #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e95aaee
fix(#609): Registries Configuration summary section overflows on smal…
rushk014 Jun 17, 2026
a7aa5dd
chore: remove no-op slice call in getSummaryData
rushk014 Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/vulnerability-scanner/components/DistributionChart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ export default {
flex-direction: column;
align-items: flex-start;
gap: 12px;
flex: 1 0 0;
flex: 1 1 0;
overflow: hidden;
.title {
display: flex;
align-items: center;
Expand Down
50 changes: 25 additions & 25 deletions pkg/vulnerability-scanner/components/RecentUpdatedRegistries.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,30 +31,30 @@ export default {
</script>

<style lang="scss" scoped>
.chart-section {
display: flex;
padding: 16px;
flex-direction: column;
align-items: flex-start;
min-width: 680px;
gap: 12px;
flex: 1 0 0;
border-right: solid var(--border-width) var(--input-border);
.title {
display: flex;
align-items: center;
gap: 8px;
font-family: Lato;
font-size: 18px;
font-style: normal;
font-weight: 400;
line-height: 21px; /* 116.667% */
margin-right: 8px;
}
.status-list {
padding: 4px 0;
align-items: center;
align-self: stretch;
}
.chart-section {
display: flex;
padding: 16px;
flex-direction: column;
align-items: flex-start;
gap: 12px;
flex: 1 0 0;
max-width: 50%;
border-right: solid var(--border-width) var(--input-border);
.title {
display: flex;
align-items: center;
gap: 8px;
font-family: Lato;
font-size: 18px;
font-style: normal;
font-weight: 400;
line-height: 21px; /* 116.667% */
margin-right: 8px;
}
.status-list {
padding: 4px 0;
align-items: center;
align-self: stretch;
}
}
</style>
128 changes: 59 additions & 69 deletions pkg/vulnerability-scanner/components/common/RegistryStatusUpdate.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,75 +80,65 @@ export default {
</script>

<style lang="scss" scoped>
.no-data {
color: var(--disabled-text);
font-family: Lato;
font-size: 14px;
font-style: normal;
font-weight: 400;
line-height: 21px;
min-height: 21px;
width: 100%;
.no-data {
color: var(--disabled-text);
font-family: Lato;
font-size: 14px;
font-style: normal;
font-weight: 400;
line-height: 21px;
min-height: 21px;
width: 100%;
}
.registry-status-record {
display: flex;
padding: 4px 0;
align-items: center;
align-self: stretch;
overflow: hidden;

.registry-name,
.uri {
padding: 0 16px;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}
.registry-status-record {
display: flex;
padding: 4px 12px;
align-items: center;
align-self: stretch;
.registry-name {
display: -webkit-box;
-webkit-box-orient: vertical;
-webkit-line-clamp: 1;
flex: 6;
overflow: hidden;
color: #5696CE;
text-overflow: ellipsis;
font-family: Lato;
font-size: 14px;
font-style: normal;
font-weight: 400;
line-height: 21px;
}
.uri {
display: -webkit-box;
-webkit-box-orient: vertical;
-webkit-line-clamp: 1;
flex: 10;
overflow: hidden;
text-overflow: ellipsis;
word-break: break-all;
font-family: Lato;
font-size: 14px;
font-style: normal;
font-weight: 400;
line-height: 21px;
margin-right: 8px;
}
.prev-status {
flex: 5;
}
.arrow {
flex: 2;
width: 16px;
height: 16px;
// background: url('../../assets/img/right.svg') no-repeat center center;
// background-size: contain;
}
.curr-status {
flex: 5;
}
.update-time {
color: var(--disabled-text);
flex: 6;
margin-left: 8px;
font-family: Lato;
font-size: 14px;
font-style: normal;
font-weight: 400;
line-height: 21px;
}
&:hover {
background-color: var(--sortable-table-selected-bg);
}

.registry-name {
display: block; // RouterLink renders as <a> (inline by default)
flex: 1 0 0;
min-width: 64px;
}

.uri {
flex: 1 0 200px;
}

.prev-status,
.arrow,
.curr-status {
display: flex;
flex-shrink: 0;
height: 24px;
padding: 0 4px;
align-items: center;
}

.prev-status,
.curr-status {
width: 85px;
}

.update-time {
color: var(--disabled-text);
width: 90px;
padding: 0 16px;
white-space: nowrap;
}

&:not(:has(.no-data)):hover {
background-color: var(--sortable-table-selected-bg);
}
}
</style>
2 changes: 2 additions & 0 deletions pkg/vulnerability-scanner/components/common/StatusBadge.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ export default {
-webkit-box-orient: vertical;
-webkit-line-clamp: 1;
line-clamp: 1;
overflow: hidden;
white-space: nowrap;
font-family: Lato;
font-size: 12px;
font-style: normal;
Expand Down
5 changes: 2 additions & 3 deletions pkg/vulnerability-scanner/pages/c/_cluster/vulnerability-scanner/RegistriesConfiguration.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,8 @@ export default {
});

});
// Sort and limit the registryStatusList to 5 most recent updates
registryStatusList.sort((a, b) => new Date(b.lastTransitionTime) - new Date(a.lastTransitionTime)).slice(0, 5);
// Sort the registryStatusList by most recent update
registryStatusList.sort((a, b) => new Date(b.lastTransitionTime) - new Date(a.lastTransitionTime));

@rushk014 rushk014 Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the .slice(0, 5) is redundant since the return value is never assigned. The top5StatusUpdates from which registryStatusList is computed is already truncated above on L186 so the length will always be <= 5

while (registryStatusList.length < 5) {
registryStatusList.push({
registryName: '',
Expand Down Expand Up @@ -384,7 +384,6 @@ export default {

.summary-section {
display: flex;
min-width: 1360px;
align-items: flex-start;
align-self: stretch;
border-radius: 6px;
Expand Down