feat: add reserved memory field #1510
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYang0529
force-pushed
the
HARV-5764
branch
3 times, most recently
from
80e5a97 to
13bf428
Compare
FrankYang0529
changed the title
m-ildefons
suggested changes
Jun 5, 2025
| obj["memory_size"] = in.MemorySize | ||
| } | ||
|
|
||
| if len(in.DiskSize) > 0 { |
There was a problem hiding this comment.
Did you mean len(in.ReservedMemorySize) > 0?
There was a problem hiding this comment.
You're correct. Updated it. Thanks.
matttrach
reviewed
Jun 9, 2025
matttrach
added
area/harvester
release/v8
|
What version of Rancher or the provider is this targeting? |
|
Ignore the validate commit message error, it is from the branch update. |
|
@matttrach Thanks for the review. We may not merge it now. It's waiting for harvester/docker-machine-driver-harvester#75 and updating related driver in Rancher. |
|
Wait for PR rancher/rancher#51078. |
FrankYang0529
force-pushed
the
HARV-5764
branch
from
b5c167c to
3bbb8e9
Compare
|
What release versions is this targeting? |
matttrach
removed
the
release/v8
|
@matttrach Sorry for the late reply. This PR can work for Rancher version >= v2.12.0. |
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
HARV-5764
branch
from
3e0b220 to
4f6652b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: harvester/harvester#5764
Solution
Add reserved memory field.
Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations