feat(machine-config): harvester gpu support #1595
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walkafwalka
force-pushed
the
machine-config-harvester-vgpu
branch
2 times, most recently
from
7020d40 to
d9d10af
Compare
|
@matttrach Any bandwidth to look into this? |
walkafwalka
force-pushed
the
machine-config-harvester-vgpu
branch
from
eb750f4 to
bd1b52f
Compare
walkafwalka
force-pushed
the
machine-config-harvester-vgpu
branch
from
bd1b52f to
7339baf
Compare
ibrokethecloud
requested review from
Vicente-Cheng
and removed request for
Vicente-Cheng
m-ildefons
suggested changes
Sep 8, 2025
There was a problem hiding this comment.
I'm not a fan of letting users input JSON strings directly. Especially if there isn't ample documentation about the expected schema and other information available to users.
The vGPU information should be a subresource and the Terrafrom provider should marshall the user input into JSON automatically.
This lets us apply a wide variety of validation and makes it more user friendly, because the expected schema of the user input is better documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1030
Problem
vGPUs parameter is not supported in the Harvester config for the Machine Config resource.
Solution
Adds support for the vGPU parameter.
Testing
Specify a
vgpu_infoparameter and check that it is populated in the HarvesterConfig.Engineering Testing
Manual Testing
Currently using this fork in our environment.
Automated Testing
QA Testing Considerations
Regressions Considerations