✨Add vSphere e2e tests #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
4 times, most recently
from
3a33e7d
to
e4500f5
Compare
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
from
e4500f5
to
9dc015a
Compare
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
from
9be8a76
to
5820cd6
Compare
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
4 times, most recently
from
60b85b5
to
648372a
Compare
richardcase
reviewed
Dec 20, 2023
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
6 times, most recently
from
b55d33c
to
5cab5c8
Compare
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
2 times, most recently
from
6ccc828
to
ecd9771
Compare
richardcase
force-pushed
the
add-vsphere-e2e
branch
from
22a7f48
to
8f7fad0
Compare
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
3 times, most recently
from
91a6f99
to
1e1ad6c
Compare
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
2 times, most recently
from
9d24cf7
to
f19c2ef
Compare
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
from
f19c2ef
to
345cebf
Compare
richardcase
reviewed
Jan 8, 2024
Signed-off-by: Furkat Gofurov <[email protected]>
Signed-off-by: Furkat Gofurov <[email protected]>
"k8s.io/utils/pointer" is deprecated and instead functions in "k8s.io/utils/ptr" are used instead: to be specific, ptr.To to obtain a pointer in this case Signed-off-by: Furkat Gofurov <[email protected]>
Signed-off-by: Furkat Gofurov <[email protected]>
Use Rancher v2.8.0 and provision newer versioned child cllusters. Signed-off-by: Richard Case <[email protected]>
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
2 times, most recently
from
04d69e8
to
2a5408f
Compare
Signed-off-by: Furkat Gofurov <[email protected]>
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
from
2a5408f
to
14fc325
Compare
|
@richardcase @Danil-Grigorev thanks for the reviews, I have addressed all your suggestions in 14fc325, PTAL once again, thanks! |
Signed-off-by: Furkat Gofurov <[email protected]>
furkatgofurov7
force-pushed
the
add-vsphere-e2e
branch
from
14fc325
to
483876a
Compare
salasberryfin
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Thanks @furkatgofurov7. Tests passed locally (openSUSE Tumbleweed) after following your how-to guide. 👍🏼
richardcase
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds e2e tests for vSphere (CAPV) infrastructure provider
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #119
Special notes for your reviewer:
Checklist: