Use token based approach for system-agent #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Danil-Grigorev
force-pushed
the
snapshot-restore-token-approach
branch
3 times, most recently
from
6b5657a
to
c9eeb3c
Compare
|
To test issuing token we need a change which is not yet released in CR: kubernetes-sigs/controller-runtime#2969 Getting “ fakeSubResourceWriter does not support create for token” |
Danil-Grigorev
changed the title
alexander-demicev
previously approved these changes
Oct 18, 2024
salasberryfin
previously approved these changes
Oct 22, 2024
Reduce the footprint of the system-agent RBAC Per each cluster there will be created: - 1 system-agent ServiceAccount Per each plan there will be temporarily created: - 1 Role with access to all plan secrets for each machine - 1 Rolebinging for the role and the cluster system-agent ServiceAccount On plan completion/failure the role and rolebinding will be rewoked Per each machine there will be created: - 1 Secret for the system-agent authentication, with unique JWT bound to the secret existence in the API server, and a namespace/name pointer to the plan secret - 1 Secret for the plan execution Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
dismissed stale reviews from salasberryfin and alexander-demicev
via
c405e0e
Danil-Grigorev
force-pushed
the
snapshot-restore-token-approach
branch
from
977573c
to
c405e0e
Compare
Signed-off-by: Danil-Grigorev <[email protected]>
furkatgofurov7
previously approved these changes
Oct 24, 2024
exp/etcdrestore/controllers/etcdsnapshotrestore_controller_test.go
Outdated
Show resolved
Hide resolved
Danil-Grigorev
force-pushed
the
snapshot-restore-token-approach
branch
from
c405e0e
to
32dc863
Compare
salasberryfin
approved these changes
Oct 24, 2024
furkatgofurov7
approved these changes
Oct 24, 2024
|
I’ll try to address the rest of the comments in the followup PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Reduce the footprint of the system-agent RBAC.
Per each cluster there will be created:
Per each plan there will be temporarily created:
On plan completion/failure the role and rolebinding will be revoked
Per each machine there will be created:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #756
Special notes for your reviewer:
Checklist: