-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[updatecli] Perform replacement of CAPIVersion
in tests and e2e
#840
base: main
Are you sure you want to change the base?
[updatecli] Perform replacement of CAPIVersion
in tests and e2e
#840
Conversation
Signed-off-by: Danil-Grigorev <[email protected]>
Signed-off-by: Danil-Grigorev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Danil-Grigorev. There are other occurrences of core CAPI version that I'd suggest we also bump via updatecli:
- https://github.com/rancher/turtles/blob/main/go.mod
- https://github.com/rancher/turtles/blob/main/exp/etcdrestore/go.mod
- https://github.com/rancher/turtles/blob/main/scripts/turtles-dev.sh
Line 164 in e031f84
CLUSTERCTL_VER := v1.7.7
Could we use this PR to cover these files too?
I think location in turtles-dev is not required to have a specified version. It additionally poses issues while running etcd snapshot restore, more details in #843. Updating I think these changes are out of scope for this PR, but make sense to give a centralized configuration to update all occurrences of |
Thanks @Danil-Grigorev. You are right, this PR's scope is well limited and we can take the discussion of what to do with other version bumps offline, as it may have other implications. |
What this PR does / why we need it:
Based on observed failure during CI execution in #835.
We perform e2e tests and integration tests, which ensure that a new turtles release will update
latest
target for provider, and will perform upgrade if thelatest
is set onCAPIProvider
.Current updatecli PRs don’t modify these values, which leads to CI failures after any
core
provider version changes.Testing is performed on Danil-Grigorev#5, which is created using
make updatecli-apply
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: