Update Fuzzer documentation and Configuration #4114
Conversation
There was a problem hiding this comment.
Hi @Logix64 thanks so much for taking this on! This is definitely a nice improvement especially the span bit. There are a couple trivial warnings from clang-tidy and some formatting things (there is a diff in the format CI job) that need to be addressed. For the RNG part I'll give more context in the original ticket.
src/fuzzer/fuzzers.h
Outdated
| std::make_shared<Botan::ChaCha_RNG>(Botan::secure_vector<uint8_t>(32)); | ||
| inline std::shared_ptr<Botan::System_RNG> fuzzer_rng_as_shared() { | ||
| static std::shared_ptr<Botan::System_RNG> rng = | ||
| std::make_shared<Botan::System_RNG>(); |
There was a problem hiding this comment.
This definitely doesn't work - the non-determinism of the RNG will confuse the fuzzer. Lets revert this bit and then take up the RNG piece in a future PR. I'll add more context in the original ticket
There was a problem hiding this comment.
Okay, thank you. I changed it in my recent commit.
|
Thanks @Logix64 this is a nice cleanup. Can you rebase then squash the last 3 commits? Other than that this looks to me ready to merge. |
This references #4061. With these changes both ASL and libFuzzer build on my device. Extending on that, I would like to continue to update the fuzzing source code, but I don't know how exactly (especially the RNG part).
Any help would be appreciated.