Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore commands for installing and updating of project from code coverage #476

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Ignore commands for installing and updating of project from code coverage #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions app/Console/Commands/BudgetInstall.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,17 @@
use Symfony\Component\Process\Exception\ProcessFailedException;
use Symfony\Component\Process\Process;

/**
* Ignoring this command from code coverage as it is dependent on binaries
* that may or may not be installed on the machine.
*
* @codeCoverageIgnore
*/
class BudgetInstall extends Command
{
protected $signature = 'budget:install';
protected $description = 'Runs most of the commands needed to make Budget work';

public function __construct()
{
parent::__construct();
}
protected $description = 'Runs most of the commands needed to make Budget work';

private function executeCommand($command): string
{
Expand Down
12 changes: 7 additions & 5 deletions app/Console/Commands/BudgetUpdate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,17 @@
use Exception;
use Illuminate\Console\Command;

/**
* Ignoring this command from code coverage as it is dependent on binaries
* that may or may not be installed on the machine.
*
* @codeCoverageIgnore
*/
class BudgetUpdate extends Command
{
protected $signature = 'budget:update';
protected $description = 'Update the application to the latest version';

public function __construct()
{
parent::__construct();
}
protected $description = 'Update the application to the latest version';

private function doesBinaryExist(string $name): bool
{
Expand Down
12 changes: 6 additions & 6 deletions app/Console/Commands/UpdateVersionFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@

use Illuminate\Console\Command;

/**
* Ignoring this command from code coverage as it is dependent on whether Git is
* installed or not, which can vary from machine to machine.
*
* @codeCoverageIgnore
*/
class UpdateVersionFile extends Command
{
protected $signature = 'app:update-version-file';

protected $description = 'Updates the version in version.txt';

/**
* Ignoring this command from code coverage as it is dependent on whether Git is
* installed or not, which can vary from machine to machine.
*
* @codeCoverageIgnore
*/
public function handle(): int
{
if (trim(shell_exec('git rev-parse --is-inside-work-tree')) !== 'true') {
Expand Down