This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
Make clammy gevent-safe #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use sendall() instead of send() - allow custom max_buffer_size - set socket timeout before connect Thanks to @mrname
|
👍 - much appreciated all around! |
|
Without @mrname's patch graingert#23 , python-clamd/clammy seem to not be gevent-safe. Would be great to see Justin's fix applied. |
stringfellow
changed the title
|
bump @ranguli - please can someone take a look at this? |
|
Hey @stringfellow, thanks for the PR and for following up - no idea why I didn't see any of these notifications when they came through in May. I'll review and merge 👍 |
|
Will try and get a new release out soon. Thanks! 🚀 |
ranguli
added a commit
that referenced
this pull request
Jan 18, 2022
* apply changes from graingert#23 (#8) - use sendall() instead of send() - allow custom max_buffer_size - set socket timeout before connect Thanks to @mrname * Add CI, code quality improvements, fix tests * Don't run pytest in CI since there's no clamd Co-authored-by: Steve Pike <[email protected]>
|
Release is now available here and on Pip. https://github.com/ranguli/clammy/releases/tag/v1.0.0 |
|
Thanks @ranguli ! :) Happy new year! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes brought in from graingert#23
Thanks to @mrname