Skip to content

fix: prevent emitting error event twice #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent emitting error event twice #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/Shell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,17 @@ class Shell extends EventEmitter {
const proc = spawn(`${psProc}${!isWin ? '' : '.exe'}`, psOpts, { stdio: 'pipe' });
this.pid = proc.pid;

proc.once('error', () => {
// if this.pid is absent an error will already have been emitted
if (this.pid) this.emit('error', new PS_PROC_ERROR());
});

// make sure the PS process start successfully
if(!this.pid) {
this.emit('error', new PS_PROC_ERROR());
return;
}
proc.once('error', () => {
this.emit('error', new PS_PROC_ERROR());
});


// set streams encoding
proc.stdin.setDefaultEncoding(options.inputEncoding || 'utf8');
Expand Down