Skip to content

test(#385): match new compress panel format in export-cmd helper - #386

Closed
ranxianglei wants to merge 1 commit into
masterfrom
2026-09-12_fix-export-cmd-format-assert
Closed

test(#385): match new compress panel format in export-cmd helper#386
ranxianglei wants to merge 1 commit into
masterfrom
2026-09-12_fix-export-cmd-format-assert

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

One-line test fix, no production code touched.

tests/export-cmd.test.ts:89 asserted the legacy compress-result format (/1 block/). #377 (cca0060) reworked the panel line to blocks: bN=mXXXXX–mYYYYY and updated four test files but missed this one — its branch predated #272's merge, so #377's CI never saw it. Result: 7 identical compress created a block failures on master (verified pre-existing on both acp-kernel 0.0.63 and 0.0.64, unrelated to any pin bump).

Verified: tests/export-cmd.test.ts 3/10 → 10/10; full suite 725/725.

Fixes #385

#377 changed the panel line from '… N blocks)' to 'blocks: bN=mXXXXX–mYYYYY'
and updated four test files but missed export-cmd.test.ts (added by #272,
merged after #377 branched) — its setup helper still asserted /1 block/,
red-ing master with 7 identical 'compress created a block' failures.
@github-actions

Copy link
Copy Markdown

📦 Built Extension Artifact

Branch: 2026-09-12_fix-export-cmd-format-assert (2e03a64)

Option A — Install from npm PR tag (recommended)

pi install npm:billion-context-pi@pr-386

Each push to this PR publishes a new version under the pr-386 npm tag.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pi-pr386.tgz
pi install ./package

This comment is automatically updated on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 Reviewed and verified — ready to merge.

Diff cleanliness: exactly 1 file, 1 line (tests/export-cmd.test.ts:89: /1 block//blocks: b1=/). No unrelated changes, no whitespace churn, no version/lockfile touched. Clean.

Local verification on branch 2026-09-12_fix-export-cmd-format-assert (commit 2e03a64, base master 2bdc831):

Regex choice: /blocks: b1=/ matches the exact fix suggested in #385 and is also consistent with tests/compress-tool.test.ts:280 which asserts the same literal span for a single-block compress. Good.

Duplicate handling: my earlier bot PR #388 (opened 06:58Z by a previous session working #385, which missed this existing PR — duplicate-screening miss on our side) fixed the same line with /blocks: b\d+=/. Since #386 was opened first (06:52Z) and matches the issue's suggested regex, I kept yours and closed #388 as duplicate with an explanation. Nothing else pending against #385.

中文摘要:审查并本地验证了这个一行测试修复(export-cmd 由 7 fail 恢复全绿,全量 725/0 fail,typecheck/build 干净),diff 只有一行、无无关改动;已把重复的机器人 PR #388 关闭并打 duplicate 标签,本 PR 可以合并。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

master 测试红:export-cmd.test.ts 仍断言旧版 compress 结果格式(/1 block/),#377 改格式时漏更新

1 participant