docs(deprecate): mark minContextLimit + modelMinLimits deprecated - #352
Conversation
…ft, no behavior change) minContextLimit (default 80%) is the lower bound for turn/iteration reminder nudges. The growth-nudge floor (minNudgeContextPercent + nudgeGrowthTokens, #343/#351) is the maintained mechanism — two parallel 'min' knobs confuse users. Soft deprecation: JSDoc @deprecated, schema [DEPRECATED] prefixes, EN/zh Status DEPRECATED + removal-consequence note, legend reworded (may still take effect until removed). zh default fixed 45% -> 80%. No behavior change; 1053/1053 unchanged.
📦 Built Plugin ArtifactBranch: Option A — Install from npm PR tag (recommended)opencode plugin opencode-acp@pr-352 --globalEach push to this PR publishes a new version under the Option B — Install from GitHubopencode plugin "github:ranxianglei/opencode-acp#2026-08-29_deprecate-min-context-limit" --globalOption C — Download artifact
tar xzf opencode-acp-pr352.tgz
cp -r package/dist ~/.cache/opencode/packages/opencode-acp@latest/node_modules/opencode-acp/dist
This comment is automatically updated on each push. |
[bot] Reviewed PR #352 ( Verified on the branch (checked out locally):
Two minor, non-blocking notes (pre-existing or follow-up, not defects in this PR):
Merge status: #343 and #351 are both still open — per the stated merge order (#343 → #351 → this), this PR is ready but must wait for them. Merging is a human-only operation per AGENTS.md §5.1.1.2; please merge yourself once the stack below lands and e2e is green: #352 |
[bot] Update: the e2e check has now completed — success. Full CI on head Nothing outstanding on my side — the PR is ready. It just needs the stack below to land first (#343 → #351 → this), and the merge itself is a human-only operation per AGENTS.md §5.1.1.2: #352 |
…in family is); merge master (v1.14.26)
…estor of already-merged master)
Model: Claude Sonnet 4.6
Stacked on #351 (which is stacked on #343) — merge order: #343 → #351 → this.
What
Marks
compress.minContextLimit(default"80%") and its per-model flat mapcompress.modelMinLimitsas deprecated. Soft deprecation only — annotations, zero behavior change (resolveContextTokenLimit(…, "min"),overMinLimit, anchor set/clear ininject.tsall untouched; suite 1053/1053 identical).Why
minContextLimitis the lower bound for turn/iteration reminder nudges. Since #343/#351, the growth-nudge floor (minNudgeContextPercent+nudgeGrowthTokens, cascading viacompress.providers) is the maintained "minimum" mechanism — two parallel "min" knobs confuse users.Changes
lib/config.ts—@deprecatedJSDoc on both fields, incl. removal consequencedcp.schema.json—[DEPRECATED — …]description prefixes (repo convention, cf.allowSubAgents)CONFIGURATION.md/CONFIGURATION.zh-CN.md— Status → DEPRECATED for both, deprecation + removal-consequence note, status legend reworded ("kept for backward compatibility, scheduled for removal (may still take effect until then)" — the old "accepted but no effect" was wrong for soft deprecation); zh default corrected 45% → 80%2026-08-29_deprecate-min-context-limit/(REQ + WORKLOG)Removal consequence (documented, not executed)
When removed, the lower-bound gating for turn/iteration reminder nudges is retired with it (those nudges depend on
overMinLimit);nudgeFrequency/iterationNudgeThresholdonly become worth revisiting at that point.