fix: always inject system prompt — revert gating that caused binge compression - #53
Merged
Merged
Conversation
…mpression System prompt gating (commit 24bbb1f) made ACP system prompt disappear between nudges. Since injections are ephemeral (not persisted to DB), the model completely forgot compression tools existed between nudges. When nudge fired after 50K growth, model panicked → 95-call binge compress. Fix: remove shouldInjectThisTurn gate from createSystemPromptHandler. System prompt (system.ts + extensions) now always injects every turn. Suffix (context level/blocks/Tips) remains gated at nudgeGrowthTokens frequency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
System prompt gating (commit 24bbb1f) made ACP system prompt disappear between nudges. Since ACP injections are ephemeral (not persisted to DB — re-injected fresh each request), the model completely forgot compression tools existed between nudges.
When nudge fired after 50K growth, model saw accumulated waste → panicked → 95-call binge compress.
Fix
Remove
shouldInjectThisTurngate fromcreateSystemPromptHandler(hooks.ts:108-112).Test
523/523 pass. Build 328K. Deployed.