Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Speed up _index_to_events #51

Merged
merged 1 commit into from
Dec 29, 2021
Merged

[ENH] Speed up _index_to_events #51

merged 1 commit into from
Dec 29, 2021

Conversation

snwnde
Copy link
Contributor

@snwnde snwnde commented Dec 24, 2021 •
edited
Loading

Issue

This PR addresses #50.

Benchmark

See #50 (comment).

Code style

flake8 reports problems in spectral.py and staging.py but I didn't touch them.

Pytest

All tests passed with some DeprecationWarning in the test codes.

Remark

I also kept the doc string Original code imported from the Visbrain package as I would expect them to accept the same enhancement, c.f. EtienneCmb/visbrain#104.

@raphaelvallat raphaelvallat self-requested a review December 26, 2021 22:54
@raphaelvallat raphaelvallat self-assigned this Dec 26, 2021
@raphaelvallat raphaelvallat added the enhancement 🚧 New feature or request label Dec 26, 2021
@raphaelvallat raphaelvallat linked an issue Dec 26, 2021 that may be closed by this pull request
[ENH] Speed up _index_to_events #50
Closed
@raphaelvallat raphaelvallat merged commit 6b2762f into raphaelvallat:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelvallat raphaelvallat Awaiting requested review from raphaelvallat

Assignees

@raphaelvallat raphaelvallat

Labels
enhancement 🚧 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] Speed up _index_to_events
2 participants
@snwnde @raphaelvallat