Skip to content

Adding Shader Parameter Config to Rio #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Adding Shader Parameter Config to Rio #1109

wants to merge 22 commits into from

Conversation

@JRBros2346
Copy link

@JRBros2346 JRBros2346 commented May 15, 2025

No description provided.

@JRBros2346
Copy link
Author

JRBros2346 commented May 20, 2025 •
edited
Loading

Updated librashader from 0.7.1 to passmeta-preset branch
Also replaced sugarloaf\src\components\filters\runtime with librashader-runtime-wgpu. Latest version supports float16, so it should not be a major problem.
Due to the previous change, i had to remove this line I don't know its significance, but hopefully its not a major problem.
Huge thanks to @chyyran for helping me out through this process.

Enumerating all the Shader Parameters now works AWESOME ✨
We shall use the Git Branch of librashader until its available in crates.io

raphamorim
raphamorim reviewed May 28, 2025
View reviewed changes
sugarloaf/src/components/filters/mod.rs Outdated
self.framecount = self.framecount.wrapping_add(1);
if let Err(err) = filter.frame(
filter_src_texture,
&*filter_src_texture,
Copy link
Owner

@raphamorim raphamorim May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this a change in the library?

Copy link
Author

@JRBros2346 JRBros2346 May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thats right. FilterChainWgpu::frame requires a &texture instead of an Arc<Texture>

@JRBros2346
Copy link
Author

JRBros2346 commented Jun 2, 2025 •
edited
Loading

Since librashader doesn't require an Arc<Texture> reference anymore, i have removed those and replaced them with &Texture references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raphamorim raphamorim Awaiting requested review from raphamorim

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JRBros2346 @raphamorim