gitignore: fixes for nix output links #1233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `result/` was ignored as a directory, which doesn't work if the `result` inode is a symlink.
- Added `result-lib`, `result-dev`, and `result-man` which are all possible (known to me) names for Nix build output links. - Removed duplicate `.direnv` entry. - Removed an incorrect comment.
|
@raphamorim I have more to contribute, but I'm wondering if these changes are welcome at all. |
|
Sorry I meant to ask if this pr was still valid after the pr you did originally |
|
Separate changes at the same time. I noticed the gitignore was messed up when I was testing my changes. |
|
My original message has a poorly phrased question however, do you want me to add another commit removing whatever I thought was useless? |
raphamorim
reviewed
Aug 21, 2025
| .direnv/ | ||
| result/ | ||
| # Nix build output | ||
| /result |
There was a problem hiding this comment.
right, so basically to exclude matches anywhere in the repo? (asking to understand the reason)
There was a problem hiding this comment.
This / prefix excludes matches only at the root of the repo. There is no trailing / because it's always a symlink, so a directory named result is fine.
You could use result as a bare name, but I don't like to make .gitignore patterns unnecessarily strict.
raphamorim
reviewed
Aug 21, 2025
| /result-dev | ||
| /result-man | ||
|
|
||
| target/ |
There was a problem hiding this comment.
This one I rather keep because I use rio in a private fork that I have been working and target is independent there for multi levels
There was a problem hiding this comment.
Why would that be the case? The repository is a workspace, and thus, target should only appear at /.
Having a directory/module named target is perfectly reasonable, perhaps a compromise would be to add !/**/src/**/target/?
Or, I'm a big fan of adding .gitignore in directories which need special handling (for offline work, for example).
KaiSforza
added a commit
to KaiSforza/rio
that referenced
this pull request
Oct 1, 2025
* Format with `alejandra` and add it to all devShells
* Use `lib.fileset` to get only the needed files for the build
* Fix build inputs for Darwin
* Make `wayland` and `x11` optional using the package args `with*`
* Create a separate `terminfo` output[^1]
* Fix nix file indentation to 2 instead of 4
* Remove `app`, `package` already has a `meta.mainProgram` attribute
* Add an overlay that can be used to override the `rio` package using
flake-part's easyOverlay module[^2]
* Create separate package for `msrv`, `stable` and `nightly`, matching
the different `devShells` available
* Removed the `flake = false` attribute for `inputs.systems`
* Create `legacyPackages.rio` containing four sub packages using
different versions of the rust-toolchain:
* `rio.msrv` - uses `./rust-toolchain.toml`
* `rio.stable` - uses `rust-bin.stable`
* `rio.nightly` - uses the latest nightly rust
* `rio.default` - Same as `rio.msrv`
* Added `/result` to get rid of the `nix build` output file[^3]
[^1]: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/ri/rio/package.nix
[^2]: https://flake.parts/options/flake-parts-easyoverlay
[^3]: A simpler version of raphamorim#1233, that _just_ adds this one line
KaiSforza
added a commit
to KaiSforza/rio
that referenced
this pull request
Oct 1, 2025
* Format with `alejandra` and add it to all devShells
* Use `lib.fileset` to get only the needed files for the build
* Fix build inputs for Darwin
* Make `wayland` and `x11` optional using the package args `with*`
* Create a separate `terminfo` output[^1]
* Fix nix file indentation to 2 instead of 4
* Remove `app`, `package` already has a `meta.mainProgram` attribute
* Add an overlay that can be used to override the `rio` package using
flake-part's easyOverlay module[^2]
* Create separate package for `msrv`, `stable` and `nightly`, matching
the different `devShells` available
* Removed the `flake = false` attribute for `inputs.systems`
* Create `legacyPackages.rio` containing four sub packages using
different versions of the rust-toolchain:
* `rio.msrv` - uses `./rust-toolchain.toml`
* `rio.stable` - uses `rust-bin.stable`
* `rio.nightly` - uses the latest nightly rust
* `rio.default` - Same as `rio.msrv`
* Added `/result` to get rid of the `nix build` output file[^3]
[^1]: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/ri/rio/package.nix
[^2]: https://flake.parts/options/flake-parts-easyoverlay
[^3]: A simpler version of raphamorim#1233, that _just_ adds this one line
Merged
KaiSforza
added a commit
to KaiSforza/rio
that referenced
this pull request
Oct 12, 2025
* Format with `alejandra` and add it to all devShells
* Use `lib.fileset` to get only the needed files for the build
* Fix build inputs for Darwin
* Make `wayland` and `x11` optional using the package args `with*`
* Create a separate `terminfo` output[^1]
* Fix nix file indentation to 2 instead of 4
* Remove `app`, `package` already has a `meta.mainProgram` attribute
* Add an overlay that can be used to override the `rio` package using
flake-part's easyOverlay module[^2]
* Create separate package for `msrv`, `stable` and `nightly`, matching
the different `devShells` available
* Removed the `flake = false` attribute for `inputs.systems`
* Create `legacyPackages.rio` containing four sub packages using
different versions of the rust-toolchain:
* `rio.msrv` - uses `./rust-toolchain.toml`
* `rio.stable` - uses `rust-bin.stable`
* `rio.nightly` - uses the latest nightly rust
* `rio.default` - Same as `rio.msrv`
* Added `/result` to get rid of the `nix build` output file[^3]
[^1]: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/ri/rio/package.nix
[^2]: https://flake.parts/options/flake-parts-easyoverlay
[^3]: A simpler version of raphamorim#1233, that _just_ adds this one line
KaiSforza
added a commit
to KaiSforza/rio
that referenced
this pull request
Oct 17, 2025
* Format with `alejandra` and add it to all devShells
* Use `lib.fileset` to get only the needed files for the build
* Fix build inputs for Darwin
* Make `wayland` and `x11` optional using the package args `with*`
* Create a separate `terminfo` output[^1]
* Fix nix file indentation to 2 instead of 4
* Remove `app`, `package` already has a `meta.mainProgram` attribute
* Add an overlay that can be used to override the `rio` package using
flake-part's easyOverlay module[^2]
* Create separate package for `msrv`, `stable` and `nightly`, matching
the different `devShells` available
* Removed the `flake = false` attribute for `inputs.systems`
* Create `legacyPackages.rio` containing four sub packages using
different versions of the rust-toolchain:
* `rio.msrv` - uses `./rust-toolchain.toml`
* `rio.stable` - uses `rust-bin.stable`
* `rio.nightly` - uses the latest nightly rust
* `rio.default` - Same as `rio.msrv`
* Added `/result` to get rid of the `nix build` output file[^3]
[^1]: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/ri/rio/package.nix
[^2]: https://flake.parts/options/flake-parts-easyoverlay
[^3]: A simpler version of raphamorim#1233, that _just_ adds this one line
KaiSforza
added a commit
to KaiSforza/rio
that referenced
this pull request
Oct 22, 2025
* Format with `alejandra` and add it to all devShells
* Use `lib.fileset` to get only the needed files for the build
* Fix build inputs for Darwin
* Make `wayland` and `x11` optional using the package args `with*`
* Create a separate `terminfo` output[^1]
* Fix nix file indentation to 2 instead of 4
* Remove `app`, `package` already has a `meta.mainProgram` attribute
* Add an overlay that can be used to override the `rio` package using
flake-part's easyOverlay module[^2]
* Create separate package for `msrv`, `stable` and `nightly`, matching
the different `devShells` available
* Removed the `flake = false` attribute for `inputs.systems`
* Create `legacyPackages.rio` containing four sub packages using
different versions of the rust-toolchain:
* `rio.msrv` - uses `./rust-toolchain.toml`
* `rio.stable` - uses `rust-bin.stable`
* `rio.nightly` - uses the latest nightly rust
* `rio.default` - Same as `rio.msrv`
* Added `/result` to get rid of the `nix build` output file[^3]
[^1]: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/ri/rio/package.nix
[^2]: https://flake.parts/options/flake-parts-easyoverlay
[^3]: A simpler version of raphamorim#1233, that _just_ adds this one line
KaiSforza
added a commit
to KaiSforza/rio
that referenced
this pull request
Oct 22, 2025
* Format with `alejandra` and add it to all devShells
* Use `lib.fileset` to get only the needed files for the build
* Fix build inputs for Darwin
* Make `wayland` and `x11` optional using the package args `with*`
* Create a separate `terminfo` output[^1]
* Fix nix file indentation to 2 instead of 4
* Remove `app`, `package` already has a `meta.mainProgram` attribute
* Add an overlay that can be used to override the `rio` package using
flake-part's easyOverlay module[^2]
* Create separate package for `msrv`, `stable` and `nightly`, matching
the different `devShells` available
* Removed the `flake = false` attribute for `inputs.systems`
* Create `legacyPackages.rio` containing four sub packages using
different versions of the rust-toolchain:
* `rio.msrv` - uses `./rust-toolchain.toml`
* `rio.stable` - uses `rust-bin.stable`
* `rio.nightly` - uses the latest nightly rust
* `rio.default` - Same as `rio.msrv`
* Added `/result` to get rid of the `nix build` output file[^3]
[^1]: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/ri/rio/package.nix
[^2]: https://flake.parts/options/flake-parts-easyoverlay
[^3]: A simpler version of raphamorim#1233, that _just_ adds this one line
raphamorim
pushed a commit
that referenced
this pull request
Oct 22, 2025
* Format with `alejandra` and add it to all devShells
* Use `lib.fileset` to get only the needed files for the build
* Fix build inputs for Darwin
* Make `wayland` and `x11` optional using the package args `with*`
* Create a separate `terminfo` output[^1]
* Fix nix file indentation to 2 instead of 4
* Remove `app`, `package` already has a `meta.mainProgram` attribute
* Add an overlay that can be used to override the `rio` package using
flake-part's easyOverlay module[^2]
* Create separate package for `msrv`, `stable` and `nightly`, matching
the different `devShells` available
* Removed the `flake = false` attribute for `inputs.systems`
* Create `legacyPackages.rio` containing four sub packages using
different versions of the rust-toolchain:
* `rio.msrv` - uses `./rust-toolchain.toml`
* `rio.stable` - uses `rust-bin.stable`
* `rio.nightly` - uses the latest nightly rust
* `rio.default` - Same as `rio.msrv`
* Added `/result` to get rid of the `nix build` output file[^3]
[^1]: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/ri/rio/package.nix
[^2]: https://flake.parts/options/flake-parts-easyoverlay
[^3]: A simpler version of #1233, that _just_ adds this one line
raphamorim
pushed a commit
that referenced
this pull request
Oct 29, 2025
* Format with `alejandra` and add it to all devShells
* Use `lib.fileset` to get only the needed files for the build
* Fix build inputs for Darwin
* Make `wayland` and `x11` optional using the package args `with*`
* Create a separate `terminfo` output[^1]
* Fix nix file indentation to 2 instead of 4
* Remove `app`, `package` already has a `meta.mainProgram` attribute
* Add an overlay that can be used to override the `rio` package using
flake-part's easyOverlay module[^2]
* Create separate package for `msrv`, `stable` and `nightly`, matching
the different `devShells` available
* Removed the `flake = false` attribute for `inputs.systems`
* Create `legacyPackages.rio` containing four sub packages using
different versions of the rust-toolchain:
* `rio.msrv` - uses `./rust-toolchain.toml`
* `rio.stable` - uses `rust-bin.stable`
* `rio.nightly` - uses the latest nightly rust
* `rio.default` - Same as `rio.msrv`
* Added `/result` to get rid of the `nix build` output file[^3]
[^1]: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/ri/rio/package.nix
[^2]: https://flake.parts/options/flake-parts-easyoverlay
[^3]: A simpler version of #1233, that _just_ adds this one line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
result/is a directory, which was supposed to be a symbolic link (file), without trailing/.result-lib,result-devandresult-manare valid Nix build outputs that should also be ignored./to prevent future confusion.There's other junk in the
.gitignorethat looks like it started from a (very bad) template. I'm not sure what else should be removed, but I see very few projects ignorerustmftbackup files (it is stable enough that these should almost never be created) andrlsis deprecated. I haven't touched these entries that I think should be removed outright.