fix(macos): Fix issue where minimized windows couldn't be restored fr… #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om Dock When all windows are minimized to the Dock on macOS, the `applicationShouldHandleReopen:hasVisibleWindows:` method's `has_open_windows` parameter remains true, preventing window restoration. This fix checks for visible (non-minimized) windows to determine whether restoration is needed, ensuring that clicking the Dock icon properly restores windows when all are minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix macOS Window Restoration from Dock When Minimized
Problem Description
On macOS, when all terminal windows are minimized to the Dock, clicking the Dock icon fails to restore these windows. Users have to manually right-click the Dock icon and select "Show All Windows" to restore minimized windows.
Root Cause
macOS's
applicationShouldHandleReopen:hasVisibleWindows:method returnstruefor thehas_open_windowsparameter even when all windows are minimized, causing the application to think there are visible windows and skip the restoration process.Solution
Modified the
should_handle_reopenmethod inapp_delegate.rsto not only check thehas_open_windowsparameter but also verify if there are actually visible (non-minimized) windows:has_open_windowsisfalsehas_open_windowsistrue, iterate through all windows to check if any are visible and non-minimizedTesting Method
This fix maintains standard macOS application behavior and improves user experience.