Fix configured arguments for spawned shells being ignored when use-fork = true
#1303
+91
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aphamorim#1016) Adds the `args` argument to `create_pty_with_fork` and pulls it through to `ContextManager::create_context`. Also merges the non-macos and macos implementations of default_shell_command since the only difference seemed to have been a hardcoded `--login` argument (which was passed in as argv[0] meaning that it wasn't getting parsed anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
use-forkis set to true in the configuration, the created processes don't receive the correct command line arguments.This is most noticeable on linux with the default configuration, as triggering
OpenConfigEditordoesn't open the configuration, just opensviwith a scratch buffer.The fix should be rather simple, just plumbing the parameters through
teletypewriter::unix::create_pty_with_forkanddefault_shell_command