fixes for cudf_pandas_opencellid_demo.ipynb #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
raybellwaves
changed the title
raybellwaves
changed the title
|
@raybellwaves thanks for creating this PR, just left a couple of comments! |
Can't see your comments |
AjayThorve
reviewed
Aug 30, 2024
Comment on lines
+103
to
+119
| "import os\n", | ||
| "import subprocess\n", | ||
| "\n", | ||
| "file_name = \"opencellid_downloader.py\"\n", | ||
| "file_url = f\"https://raw.githubusercontent.com/rapidsai-community/showcase/main/getting_started_tutorials/{file_name}\"\n", | ||
| "\n", | ||
| "if os.path.exists(file_name):\n", | ||
| " print(f\"The file '{file_name}' exists in the current directory.\")\n", | ||
| "else:\n", | ||
| " print(f\"The file '{file_name}' does not exist in the current directory. Downloading it now...\")\n", | ||
| " try:\n", | ||
| " subprocess.run([\"wget\", file_url], check=True)\n", | ||
| " print(f\"Successfully downloaded '{file_name}'.\")\n", | ||
| " except subprocess.CalledProcessError as e:\n", | ||
| " print(f\"Failed to download the file. Error: {e}\")\n", | ||
| " except FileNotFoundError:\n", | ||
| " print(\"The 'wget' command is not found. Please ensure it's installed and in your system PATH.\")" |
There was a problem hiding this comment.
I like the idea of checking if the file exists before downloading, can be done in an inline way as well to keep the cell size small:
!test -f opencellid_downloader.py || wget https://raw.githubusercontent.com/rapidsai-community/showcase/main/getting_started_tutorials/opencellid_downloader.py
Apologies, can you see them now, @raybellwaves ? |
Co-authored-by: Ajay Thorve <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
! pip install -q hvplot pydeck panel holoviews=1.18.3givesERROR: Invalid requirement: 'holoviews=1.18.3': Expected end or semicolon (after name and no valid version specifier)
holoviews=1.18.3
^
Hint: = is not a valid operator. Did you mean == ?
Added
jupyter_bokehin install to avoidI also adjusted the part to check if the script exists before downloading