Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value of RAPIDS_DEPENDENCIES="latest" #198

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 16, 2024

Recently, we added the ability to use "oldest" or "latest" dependencies in RAPIDS CI workflows. rapidsai/shared-workflows#228

However, this has hurt our ability to reproduce CI workflows locally, because RAPIDS_DEPENDENCIES is not set by default in our CI containers. This leads to errors like the following when running CI images locally:

./ci/test_python_common.sh: line 17: RAPIDS_DEPENDENCIES: unbound variable

This PR adds a default value of RAPIDS_DEPENDENCIES="latest" to aid in reproducing CI workflows. Our workflows can still set it to a non-default value to test "oldest" dependencies.

@bdice bdice requested a review from a team as a code owner October 16, 2024 02:00
@bdice bdice requested review from AyodeAwe and removed request for a team October 16, 2024 02:00
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes totally, support it

@jameslamb jameslamb removed the request for review from AyodeAwe October 16, 2024 13:38
@bdice bdice merged commit ca73a44 into rapidsai:main Oct 16, 2024
407 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants