This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
One python version per container #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
reviewed
May 25, 2023
.github/workflows/prs.yml
Outdated
There was a problem hiding this comment.
can you rename this file back to pr.yaml? That's the convention that most RAPIDS repositories follow. mambaforge-cuda is the exception:
There was a problem hiding this comment.
Should I also rename merge.yml to build.yml like other RAPIDS repos then?
|
@ajschmidt8 this is ready for a re-review |
ajschmidt8
reviewed
May 30, 2023
Co-authored-by: AJ Schmidt <[email protected]>
vyasr
suggested changes
Jun 1, 2023
There was a problem hiding this comment.
Some initial requests:
- Move the deletion of the disabled workflows to a separate PR
- Rename workflows to match the workflows used in our other repos (pr/build/test) assuming they follow the same logic (I don't think we need the equivalent of a "test" workflow nightly)
- Let's leave the
ci-wheelimages named something withmanylinuxin them. Perhapsmanylinux_cuda? I still want that use case to be clear. - Can we separate change to the manylinux containers from changes to the citestwheel images (separate PRs)?
Hmm. I was hoping to keep these as Once that happens, I assumed we'd have two images in that repository: Any thoughts on this approach? |
ajschmidt8
reviewed
Jun 1, 2023
vyasr
approved these changes
Jun 1, 2023
Co-authored-by: AJ Schmidt <[email protected]>
ajschmidt8
approved these changes
Jun 1, 2023
vyasr
pushed a commit
to rapidsai/shared-workflows
that referenced
this pull request
Jun 29, 2023
rapidsai/cibuildwheel-imgs#22 allowed for new wheel containers to be built with only one python version per container
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.