Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Add PIP_EXTRA_INDEX_URL and gh tool to build images #29

Merged
merged 10 commits into from
Jul 19, 2023

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Jul 18, 2023

Depends on rapidsai/gha-tools#57

This PR adds:

  • PIP_EXTRA_INDEX_URL : Environment variable for RAPIDS wheels index
  • gh : CLI tool to generate RAPIDS_DATE_STRING

@divyegala
Copy link
Member Author

@ajschmidt8 could you re-review? I added gh tool to the images

@divyegala divyegala changed the title Add PIP_EXTRA_INDEX_URL to build image Add PIP_EXTRA_INDEX_URL and gh tool to build images Jul 19, 2023
@divyegala divyegala changed the title Add PIP_EXTRA_INDEX_URL and gh tool to build images Add PIP_EXTRA_INDEX_URL and gh tool to build images Jul 19, 2023
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these changes install the gh CLI via the OSes native package managers, the installed versions will likely be different.

To keep the versions consistent across our images, I think it might be better to install gh using the artifacts on their release pages: https://github.com/cli/cli/releases.

It looks like they have a tarball for each architecture (arm64 and amd64) that we can extract to get the actual gh binary.

For now we can hardcode the version to their latest release, 2.32.0.

When we move these images over to the rapidsai/ci-imgs repository, we can configure the renovate bot to open PRs to keep the version updated for us. See the references below for more about renovate:

Copy link
Collaborator

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming AJ's request regarding gh CLI installation is addressed.

@ajschmidt8
Copy link
Member

Based on the logs, it looks like Ubuntu installed the latest version (which is expected since you added the PPA), but CentOS actually didn't install any version at all:

@divyegala
Copy link
Member Author

@ajschmidt8 do you know off the top of your head where should I unpack these tarballs so gh is available in PATH seamlessly?

@ajschmidt8
Copy link
Member

@ajschmidt8 do you know off the top of your head where should I unpack these tarballs so gh is available in PATH seamlessly?

/usr/local/bin is probably a safe bet.

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's check the GHAs logs before merging this to make sure they look right, but this looks good to me.

@ajschmidt8 ajschmidt8 merged commit 79f0d28 into rapidsai:main Jul 19, 2023
0 of 4 checks passed
vyasr added a commit to rapidsai/shared-workflows that referenced this pull request Jul 19, 2023
This PR tries to minimize custom logic in wheel building workflows by
trying to mirror conda builds closer and moving wheel building logic to
downstream repositories. The PR achieves this by adding a new workflow
`wheels-build.yaml`

Depends on rapidsai/cibuildwheel-imgs#29

---------

Co-authored-by: Vyas Ramasubramani <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants