Fix CI #60
Merged
Fix CI #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
|
CI seems to be passing again . CC: @marcromeyn / @edknv for quick eyes on this. |
VibhuJawa
commented
Jul 17, 2024
| @@ -29,7 +29,7 @@ def __init__(self): | |||
| def concatenate(self, series_list, *, axis=None): | |||
| return cudf.concat(series_list, axis=axis or 0) | |||
|
|
|||
| np_backend_dispatch.register((cudf.Series, cudf.GenericIndex))(CudfBackend()) | |||
| np_backend_dispatch.register((cudf.Series, cudf.Index))(CudfBackend()) | |||
There was a problem hiding this comment.
Unsure if this is the right fix. CC: @rjzamora
There was a problem hiding this comment.
Yes, this looks correct to me. My understanding is that all "real" index objects inherit from Index now.
I suppose dask-cudf uses BaseIndex, but that dispatch was added a long time ago (and BaseIndex is probably unnecessary).
There was a problem hiding this comment.
Thanks a ton for confirming this .
sarahyurick
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables GPU CI on this repo:
Tested locally using: